----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22632/#review45763 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On June 16, 2014, 3:22 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22632/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 3:22 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-6134 > https://issues.apache.org/jira/browse/AMBARI-6134 > > > Repository: ambari > > > Description > ------- > > > Change the help text on '--jdbc-driver'... > > Specifies the path to the JDBC driver JAR file for the database type > specified with the --jdbc-db option. Used only with --jdbc-db option. > > ==== > > Change the help text on '--jdbc-db'... > > Specifies the database type [postgres|mysql|oracle] for the JDBC driver > specified with the --jdbc-driver option. Used only with --jdbc-driver option. > > ==== > > One more thing: notice above i used postgres, not postgresql. Can we make the > option postgres, not postgresql? Because in the --database option that > already exists, we used postgres (so to maintain consistency, can we go with > postgres here with --jdbc-driver)? > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py 966d3ea > ambari-server/src/main/resources/custom_actions/check_host.py c88b04d > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py > 0f618b8 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py > f953267 > ambari-server/src/test/python/TestAmbariServer.py e7563e2 > > Diff: https://reviews.apache.org/r/22632/diff/ > > > Testing > ------- > > success > > > Thanks, > > Vitalyi Brodetskyi > >
