----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22729/#review46070 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/utils.py <https://reviews.apache.org/r/22729/#comment81223> why do we need this line? This will not fail if we don't have file. It works just like ensure present in puppet - Andrew Onischuk On June 18, 2014, 2:08 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22729/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 2:08 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-6184 > https://issues.apache.org/jira/browse/AMBARI-6184 > > > Repository: ambari > > > Description > ------- > > During wrong kerberos setup DN processes fail to start, but leave stale pid > file owned by root. Next one DN start command starts DN process, but can not > override pid file. So the server considers DN as stopped. If we start DN once > more, commands fail soon after start (due to lock file at data dir owned by > already running DN). Agent reports to server that DN is not running, so > server displays a correct information from his point of view. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/utils.py > cf15f1e > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py 3290865 > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_namenode.py f60c7a2 > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_snamenode.py 942093c > > Diff: https://reviews.apache.org/r/22729/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 215 tests in 1.585s > > OK > ---------------------------------------------------------------------- > Total run:572 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmitro Lisnichenko > >
