----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22954/#review46637 -----------------------------------------------------------
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java <https://reviews.apache.org/r/22954/#comment82142> Was this logging left in on purpose or something left over from testing? If it's on purpose, is INFO the right level? Wouldn't this result in a lot of logging since this will be called frequently? - Tom Beerbower On June 25, 2014, 12:33 p.m., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22954/ > ----------------------------------------------------------- > > (Updated June 25, 2014, 12:33 p.m.) > > > Review request for Ambari, Mahadev Konar and Tom Beerbower. > > > Bugs: AMBARI-6266 > https://issues.apache.org/jira/browse/AMBARI-6266 > > > Repository: ambari > > > Description > ------- > > Get sql metrics logic should be reviewed > > > Diffs > ----- > > > contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java > 49508ea > > contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/SQLPropertyProviderTest.java > d0298f3 > > Diff: https://reviews.apache.org/r/22954/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 34.066s > [INFO] Finished at: Wed Jun 25 15:14:37 EEST 2014 > [INFO] Final Memory: 37M/257M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Artem Baranchuk > >
