> On June 26, 2014, 2:33 p.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java, > > lines 346-349 > > <https://reviews.apache.org/r/22941/diff/5/?file=618291#file618291line346> > > > > So the comment says that we want to build a new resource set if there > > is a page request and the predicate doesn't contain properties that haven't > > been set yet. Is that what is being tested for? Don't we need to worry > > about this case? ... > > > > Get a page of 10 hosts on a 1000 host cluster where > > metrics/cpu/cpu_num<2 > > > > There is a page request and no sub-resource predicate so with the code > > as you have it, I think it would build a page of resources that could get > > thrown out after they are populated with the metrics/cpu/cpu_num values. > > > > That is what the predicateRequiresPopulation() check was for in my > > earlier comment. > > > > > > Dmytro Sen wrote: > Checking
Now using your version - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22941/#review46742 ----------------------------------------------------------- On June 26, 2014, 12:51 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22941/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 12:51 p.m.) > > > Review request for Ambari, Sid Wagle and Tom Beerbower. > > > Bugs: AMBARI-6263 > https://issues.apache.org/jira/browse/AMBARI-6263 > > > Repository: ambari > > > Description > ------- > > On a large cluster, calls to /hosts are taking more than 30 seconds. > This severely impacts the responsiveness of the UI for the Hosts page (it > takes > 30 seconds to filter, navigate through paged hosts, etc). > The times shown are latency only (does not include download time). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java > 8017844 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java > b7893c5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > 711e64e > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ClusterController.java > 5e3f844 > > ambari-server/src/main/java/org/apache/ambari/server/utils/JaxbMapKeyListAdapter.java > 4589948 > > ambari-server/src/main/java/org/apache/ambari/server/utils/JaxbMapKeyMapAdapter.java > 8419d73 > > ambari-server/src/main/java/org/apache/ambari/server/utils/JaxbMapKeyValAdapter.java > e3531cd > > Diff: https://reviews.apache.org/r/22941/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [1.632s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s] > [INFO] Ambari Web ........................................ SUCCESS [22.921s] > [INFO] Ambari Views ...................................... SUCCESS [1.546s] > [INFO] Ambari Server ..................................... SUCCESS > [14:21.956s] > [INFO] Ambari Agent ...................................... SUCCESS [6.150s] > [INFO] Ambari Client ..................................... SUCCESS [0.035s] > [INFO] Ambari Python Client .............................. SUCCESS [0.291s] > [INFO] Ambari Groovy Client .............................. SUCCESS [8.195s] > [INFO] Ambari Shell ...................................... SUCCESS [4.434s] > > > Thanks, > > Dmytro Sen > >
