> On June 27, 2014, 2:36 p.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java, > > lines 321-322 > > <https://reviews.apache.org/r/23127/diff/1/?file=619389#file619389line321> > > > > This was just to help organize the class methods. I think it helps > > visualize what a class is used for when you can see all of its public > > methods together. I use the headings to try to keep things organized. I'm > > not sure why you want to remove it but whatever... > > Dmytro Sen wrote: > Because now it's overrided from ClusterController interface.
All public ClusterControllerImpl now overrided from ClusterController interface - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23127/#review46858 ----------------------------------------------------------- On June 27, 2014, 1:40 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23127/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 1:40 p.m.) > > > Review request for Ambari, Sid Wagle and Tom Beerbower. > > > Bugs: AMBARI-6306 > https://issues.apache.org/jira/browse/AMBARI-6306 > > > Repository: ambari > > > Description > ------- > > Slowness of filtering operations on hosts, opening a JIRA to track the > performance aspect of it. > In general, filtering operations available on the Hosts page (such as > filtering by host_status, hostname, ip, etc., are slow and takes more than 40 > seconds on a 2k-node cluster). > > After the patch response time is 1-3 seconds, if there is no subresources in > predicate > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java > ec8a3d4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java > 3f8f317 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java > 51c7565 > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ClusterController.java > d7d916e > > Diff: https://reviews.apache.org/r/23127/diff/ > > > Testing > ------- > > Fixing > > > Thanks, > > Dmytro Sen > >
