----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23304/#review47379 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On July 7, 2014, 11:01 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23304/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 11:01 a.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-6394 > https://issues.apache.org/jira/browse/AMBARI-6394 > > > Repository: ambari > > > Description > ------- > > If you put in a bogus/bad base url for a repo, a full stack trace is dumped > to ambari-server.log. We should more gracefully print the error message. Full > stack trace in this case should be reserved for DEBUG log. > > Short patch description: > 1) Check if LOG.isDebugEnabled() and write to log message short exception > message OR full stacktrace > 2) Rework check URLs (more grace loop) > 3) Write to log message and UI more clear message about exceptions > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 21ff0ff > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 7ad064b > > Diff: https://reviews.apache.org/r/23304/diff/ > > > Testing > ------- > > > Thanks, > > Dmytro Sen > >
