----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23308/#review47386 -----------------------------------------------------------
Ship it! Ship It! - Andrew Onischuk On July 7, 2014, 3:02 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23308/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 3:02 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-6399 > https://issues.apache.org/jira/browse/AMBARI-6399 > > > Repository: ambari > > > Description > ------- > > I think it's a bad idea to use "--force-yes" since documentation states that > "This is a dangerous option that will cause apt to continue without prompting > if it is doing something potentially harmful. It should not be used except in > very special situations. Using force-yes can potentially destroy your system!" > It's better to use --allow-unauthenticated option instead > > > Diffs > ----- > > > ambari-agent/src/main/python/resource_management/core/providers/package/apt.py > 0e9177c > ambari-agent/src/test/python/resource_management/TestPackageResource.py > cc9a1d7 > ambari-server/src/main/python/setupAgent.py e83ed3f > ambari-server/src/main/resources/scripts/kerberos-setup.sh 099b8ea > > Diff: https://reviews.apache.org/r/23308/diff/ > > > Testing > ------- > > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 157 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [1.792s] > [INFO] Ambari Server ..................................... SUCCESS [17.652s] > [INFO] Ambari Agent ...................................... SUCCESS [7.741s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 27.757s > [INFO] Finished at: Mon Jul 07 17:48:01 EEST 2014 > [INFO] Final Memory: 50M/1137M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
