----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23342/#review47514 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_service.py <https://reviews.apache.org/r/23342/#comment83429> It doesn't look like "output" ever gets assigned anything. The first time through the loop it gets {} and [] for alert_home, alert_name ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_service.py <https://reviews.apache.org/r/23342/#comment83428> Maybe use the variable name 'alert' here instead of 'a' for better readability? - Jonathan Hurley On July 9, 2014, 2:48 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23342/ > ----------------------------------------------------------- > > (Updated July 9, 2014, 2:48 p.m.) > > > Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-6421 > https://issues.apache.org/jira/browse/AMBARI-6421 > > > Repository: ambari > > > Description > ------- > > Preview phase 2 for alerts - take alerts generated from agents and push them > to Nagios via a status command. The agent on nagios will then persist that > information and read from a plugin. > > This will the basis for broader scale alert work in the future while > supporting Flume in today's code. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 5fa4062 > > ambari-server/src/main/java/org/apache/ambari/server/agent/NagiosAlertCommand.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java > ce1dc2f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_ambari_alerts.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server.py > ed7cebc > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py > 95bdd9f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_service.py > 8f47702 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py > 42ccb35 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/status_params.py > 33b35fe > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 > caf0ff4 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 > 0e92dab > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 > fa45016 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java > 65d5a96 > > ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java > 6456860 > > ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java > 92d3c40 > ambari-server/src/test/python/stacks/2.0.6/NAGIOS/test_nagios_server.py > 6ae0b24 > > Diff: https://reviews.apache.org/r/23342/diff/ > > > Testing > ------- > > Shuffled test case code to appropriate test files. Also fixed a broken test > case that is unrelated to this patch. > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 15:17.249s > [INFO] Finished at: Tue Jul 08 14:49:18 EDT 2014 > [INFO] Final Memory: 21M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
