----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23454/#review47721 -----------------------------------------------------------
Ship it! Would be nice to have a test for the command being run, but I realize it probably isn't being tested already. - Nate Cole On July 14, 2014, 1:12 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23454/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 1:12 p.m.) > > > Review request for Ambari, Dmytro Sen and Nate Cole. > > > Bugs: AMBARI-6478 > https://issues.apache.org/jira/browse/AMBARI-6478 > > > Repository: ambari > > > Description > ------- > > Using "tar" as root causes the resulting files to be owned by uucp. > Specifying the --no-same-owner fixes this. > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py 8aec854 > > Diff: https://reviews.apache.org/r/23454/diff/ > > > Testing > ------- > > Installed ambari-server and verified the directory ownership is correct: > > [root@c6404 jdk64]# ll > total 4 > drwxr-xr-x 8 root root 4096 Oct 8 2013 jdk1.7.0_45 > > > Tests: > ---------------------------------------------------------------------- > Total run:571 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Jonathan Hurley > >
