----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23836/#review48548 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On July 22, 2014, 10:40 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23836/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 10:40 p.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-6569 > https://issues.apache.org/jira/browse/AMBARI-6569 > > > Repository: ambari > > > Description > ------- > > Full CRUD support for AlertDefinitions. Also updated javadoc/misc comments > from previous issues. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java > ee3d29a > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > c8ccf9a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java > c83615a > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java > f8df108 > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricAlert.java > b565a3f > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/Source.java > PRE-CREATION > ambari-server/src/main/resources/properties.json 4d5407c > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json > c1918e5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java > de48756 > ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json > 7988d8b > > Diff: https://reviews.apache.org/r/23836/diff/ > > > Testing > ------- > > Manual testing + new tests: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 16:48.151s > [INFO] Finished at: Tue Jul 22 22:37:59 EDT 2014 > [INFO] Final Memory: 21M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
