----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23921/#review48723 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionType.java <https://reviews.apache.org/r/23921/#comment85479> Can you please make endpoint name more general (like connection properties or similar), this will better reflect response content and allow future extension. - Myroslav Papirkovskyy On July 25, 2014, 1:03 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23921/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 1:03 p.m.) > > > Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty. > > > Bugs: AMBARI-6608 > https://issues.apache.org/jira/browse/AMBARI-6608 > > > Repository: ambari > > > Description > ------- > > Currently, agent uses a implicit mechanism to decide whether to use two-way > ssl. It tries to connect normally and if it fails it switches to using > two-way ssl. > We should improve this setup to make it explicit. The initial GET call agent > makes (server:8440/cert/ca) should return a response providing the > requirement from the agent (e.g. "two_way_ssl" : "true" ). Agent should use > this data and decide on the nature of the connection. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/Controller.py bf68616 > ambari-agent/src/main/python/ambari_agent/NetUtil.py 42d3875 > ambari-agent/src/main/python/ambari_agent/main.py 7ea70ea > ambari-agent/src/main/python/ambari_agent/security.py c4cb746 > ambari-agent/src/test/python/ambari_agent/TestMain.py 7cf14b6 > ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 10ddca3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 497d3f7 > > ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java > 9d4e603 > > ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionType.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23921/diff/ > > > Testing > ------- > > Tests run: 1834, Failures: 1, Errors: 289, Skipped: 13 > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [3.483s] > [INFO] Ambari Server ..................................... FAILURE [9:33.696s] > [INFO] Ambari Agent ...................................... SKIPPED > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 9:37.743s > [INFO] Finished at: Fri Jul 25 12:50:23 FET 2014 > [INFO] Final Memory: 23M/319M > [INFO] > ------------------------------------------------------------------------ > > same tests fail on trunk > > Agent tests: > ---------------------------------------------------------------------- > Ran 288 tests in 3.663s > > OK > [INFO] > [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-agent --- > [INFO] 51 implicit excludes (use -debug for more details). > [INFO] Exclude: src/examples/* > [INFO] Exclude: src/test/python/dummy*.txt > [INFO] Exclude: src/test/python/ambari_agent/dummy_files/* > [INFO] Exclude: src/test/python/ambari_agent/dummy*.txt > [INFO] Exclude: src/main/python/ambari_agent/imports.txt > [INFO] Exclude: **/*.erb > [INFO] Exclude: **/*.json > [INFO] Exclude: **/*.pydevproject > [INFO] 291 resources included (use -debug for more details) > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 157 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 6.625s > [INFO] Finished at: Fri Jul 25 12:59:26 FET 2014 > [INFO] Final Memory: 11M/149M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
