----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24153/#review49241 -----------------------------------------------------------
With regard to blueprint (John can probably answer) - do we need to worry about loading a blueprint out of the database? ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/24153/#comment86130> Seems like adding configurations named 'global' shoudl still be allowed, even if we don't use it. We should ADD a -env set if a name was found, but not remove the key/value pair from what was passed in. That makes the behavior confusing: "I passed in a name and value that wasn't saved" ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/24153/#comment86127> add spaces around the : ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java <https://reviews.apache.org/r/24153/#comment86126> Depracted shold be Deprecated - Nate Cole On July 31, 2014, 12:09 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24153/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 12:09 p.m.) > > > Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-6695 > https://issues.apache.org/jira/browse/AMBARI-6695 > > > Repository: ambari > > > Description > ------- > > How to handle support for blueprints + configs API where global configs are > set, since global config_type is being eliminated. > > * warn that global is deprecated > * map global to whatever-the-new-config-type automatically > > jspeidel this affects blueprints and the configs API > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 7f53ded > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 906cba4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java > b3a8019 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > b72beb6 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 81c3c38 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java > 5f67a30 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > d8f7fbc > > Diff: https://reviews.apache.org/r/24153/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
