> On Aug. 6, 2014, 11:44 a.m., Nate Cole wrote: > > AMCI has a method getAuthName() - does that need to change given the other > > username-ification that is included with this patch?
Thanks for reviewing. I didn't see that. Thanks for pointing it out. Looks like the AMCI uses AuthorizationHelper. No need to have both that and SecurityHelper. I'll refactor to remove the duplication. > On Aug. 6, 2014, 11:44 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 562 > > <https://reviews.apache.org/r/24212/diff/1/?file=649218#file649218line562> > > > > ControllerModule seems to be binding SecurityHelper.class to > > SecurityHelperImpl - can you use the injector and pass the interface > > instead? Yes. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24212/#review49725 ----------------------------------------------------------- On Aug. 5, 2014, 10:43 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24212/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 10:43 a.m.) > > > Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, Sumit > Mohanty, and Sid Wagle. > > > Bugs: AMBARI-6723 > https://issues.apache.org/jira/browse/AMBARI-6723 > > > Repository: ambari > > > Description > ------- > > Hook up the pieces from the related Jiras, including ... > > * Make sure that privileges are enforced as described in the doc... > > https://docs.google.com/a/hortonworks.com/document/d/1heCrAA6hNM8qvQ091f8KGICABw2pY6Pt25uyfAvV8SQ/edit?disco=AAAAAJqU6lg# > > On initial install the default ‘admin’ user is automatically granted the > AMBARI.ADMIN permission on the Ambari resource. A user that has the > AMBARI.ADMIN privilege may grant any permissions (including AMBARI.ADMIN) to > any user. > > New users initially have no privileges. They must be granted by a user with > the AMBARI.ADMIN privilege. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java > e80a90b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java > e9556f8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > d61b1b7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > fc049a4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > f7d2ed1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProvider.java > a29f3c8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > f99955b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java > 559f415 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > 5b48679 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java > fa01bb6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrivilegeDAO.java > 7fed17b > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java > 8889bde > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > fa303c7 > > ambari-server/src/main/java/org/apache/ambari/server/security/SecurityHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/SecurityHelperImpl.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariGrantedAuthority.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java > c609d04 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserDetailsService.java > 34ebbd8 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java > b67a843 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/internal/InternalTokenAuthenticationFilter.java > c05de28 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 1d74038 > ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java > eb00a97 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 3d2365c > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java > 1ded03c > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 58e68c2 > ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml bb232b7 > > ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java > 7a23293 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterServiceTest.java > 238dc83 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProviderTest.java > 681119c > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > d1aa4d5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java > 918b19c > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java > c93465a > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java > caffd02 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestAmbariLdapAuthoritiesPopulator.java > 54ec977 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > fbe1c90 > > Diff: https://reviews.apache.org/r/24212/diff/ > > > Testing > ------- > > Manual tests. > > All unit tests pass... > > Results : > > Tests run: 1857, Failures: 0, Errors: 0, Skipped: 13 > > > Thanks, > > Tom Beerbower > >
