----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24421/#review49894 -----------------------------------------------------------
Ship it! Tested this patch end-to-end with https://reviews.apache.org/r/24450/ - Dmytro Sen On Aug. 7, 2014, 1:27 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24421/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 1:27 p.m.) > > > Review request for Ambari, Dmytro Sen, Mahadev Konar, and Sid Wagle. > > > Bugs: AMBARI-6760 > https://issues.apache.org/jira/browse/AMBARI-6760 > > > Repository: ambari > > > Description > ------- > > Patch implements cancelling commands and requests inside server, sending > CANCEL_COMMANDs to agent and handling agent response properly. > > Also, removed unused method scheduleHostRole from > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > Also at patch I've reverted removal of Request status field that is expected > to be used later instead of calculating request status on the fly. > Also, I've reverted to previous value of actionTimeout. > > Failing tests have been @ignore'd and will be fixed (and unit tests for new > code will be added) in a separate jira. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 1ba6b94 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java > 3bcf8c2 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > 3c6668b > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java > 039579f > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > 74eb6c1 > > ambari-server/src/main/java/org/apache/ambari/server/agent/AgentCommand.java > ec7c58f > > ambari-server/src/main/java/org/apache/ambari/server/agent/AgentCommand.java > ec7c58f > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > bccbc02 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java > 67a4815 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > fc049a4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > 838cf38 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 578c5dd > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java > 4dfb63c > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > 9e6e330 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > c415e15 > > Diff: https://reviews.apache.org/r/24421/diff/ > > > Testing > ------- > > Failed tests: > testIgnoreCustomActionReport(org.apache.ambari.server.agent.TestHeartbeatHandler) > > Tests in error: > > testHeartbeatWithConfigs(org.apache.ambari.server.agent.TestHeartbeatHandler) > > testHeartbeatCustomCommandWithConfigs(org.apache.ambari.server.agent.TestHeartbeatHandler) > > testHeartbeatCustomStartStop(org.apache.ambari.server.agent.TestHeartbeatHandler) > > testTaskInProgressHandling(org.apache.ambari.server.agent.TestHeartbeatHandler) > > testCommandReportOnHeartbeatUpdatedState(org.apache.ambari.server.agent.TestHeartbeatHandler) > > testUpgradeSpecificHandling(org.apache.ambari.server.agent.TestHeartbeatHandler) > > testComponentUpgradeCompleteReport(org.apache.ambari.server.agent.TestHeartbeatHandler) > > testComponentUpgradeInProgressReport(org.apache.ambari.server.agent.TestHeartbeatHandler) > > testProcessStatusReports(org.apache.ambari.server.agent.TestHeartbeatHandler) > > Tests run: 1861, Failures: 1, Errors: 9, Skipped: 13 > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [3.115s] > [INFO] Ambari Server ..................................... FAILURE > [16:05.504s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 16:09.227s > [INFO] Finished at: Wed Aug 06 22:56:11 FET 2014 > [INFO] Final Memory: 30M/336M > > > Thanks, > > Dmitro Lisnichenko > >
