-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24652/
-----------------------------------------------------------

(Updated Aug. 13, 2014, 3:49 p.m.)


Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-6848
    https://issues.apache.org/jira/browse/AMBARI-6848


Repository: ambari


Description
-------

When a user wants to "go back" (revert) to a set of configs for a specific 
serviceconfigversion, this should create a new serviceconfigversion.
For example: v1, v2, v3, v4 and v5 (current)
If user wants to "go back/revert" to v2 of the configs, they want to create v6 
of the serviceconfigversion which is set to all the props of v2 (i.e. a clone).


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java
 765e765 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java
 a265e73 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
 698e655 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigApplicationEntity.java
 ba5adb5 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java
 2727388 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 3daf32a 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
 9a0f4ca 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b4c7fb6 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 87d0fd9 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql bec8fd9 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
0dd33af 
  ambari-server/src/main/resources/properties.json e515b91 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ServiceConfigEntityTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
 63b64e4 

Diff: https://reviews.apache.org/r/24652/diff/


Testing (updated)
-------

Added unit tests for ServiceConfigDAO and ServiceConfigEntity. Tests passed

Results :

Tests run: 1927, Failures: 0, Errors: 0, Skipped: 14


Thanks,

Dmytro Sen

Reply via email to