----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24800/#review50885 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Aug. 18, 2014, 11:12 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24800/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2014, 11:12 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-6890 > https://issues.apache.org/jira/browse/AMBARI-6890 > > > Repository: ambari > > > Description > ------- > > When all alerts for a given host have been removed, the NULL MD5 hash should > be sent along with an empty array of definitions to each agent affected by > the change. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/AgentCommand.java > 29805a18977f557e5aa2a00065f5bcad39397505 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CancelCommand.java > 55de9ea8b0ff1465eb0e3c6a451f1a86a895027f > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > fdf96df2602661be7f6c040579489e4201902a03 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java > 0dff507858050f1c6fb07eba291e4eed5da813bb > > ambari-server/src/main/java/org/apache/ambari/server/agent/NagiosAlertCommand.java > f8e2f26ff90996fd1527d286ab34bd4e6904f00f > > ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java > 9ac8bedbc0c62d59c99d79942cc91e4123f7192a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java > a63919778303d355f0fb57d2e6402c03877f16e4 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java > 3e8b15b6e30cfc95c186fe9e410f1d3e0f79c7a1 > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java > 7160bcf92583b534c5b6ae95430d28d90bbec658 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > b1b83fa3c54ffa2d5f24d5ef978c823b2fc6452b > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 9ca5348392649a7856b1d01e2441ea9ad8e5adc9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java > a9826dfed069330ed5251c48af5e275c54edbe1e > > ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java > 6e587f1ac60ee5c6e43178447ca56be5a2add4e5 > ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/24800/diff/ > > > Testing > ------- > > Ran mvn clean test; > > Observed many failures, but all were also observed on trunk and therefore not > related to my changes. The 2 unit tests that differed did related to my > changes and have been fixed. > > > Thanks, > > Jonathan Hurley > >
