----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24893/#review51105 -----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py <https://reviews.apache.org/r/24893/#comment89081> Without the cache directory, I'd think we were hosed; If it can't create it maybe we need to log a SEVERE ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py <https://reviews.apache.org/r/24893/#comment89084> Any reason we don't dump alert_commands directly instead of iterating over each command? ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py <https://reviews.apache.org/r/24893/#comment89085> METRIC, PORT, etc should probably extracted out to a common location. ambari-agent/src/main/python/ambari_agent/Controller.py <https://reviews.apache.org/r/24893/#comment89086> Awesome! - Jonathan Hurley On Aug. 20, 2014, 10:41 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24893/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 10:41 a.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-6942 > https://issues.apache.org/jira/browse/AMBARI-6942 > > > Repository: ambari > > > Description > ------- > > Save definitions in a cache directory. Send data back to Ambari. The data > is currently not consumed by the server correctly, that will be a future task. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py cd0605f > ambari-agent/src/main/python/ambari_agent/Controller.py 3be54c2 > ambari-agent/src/main/python/ambari_agent/Heartbeat.py 37a97e8 > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py e102d56 > ambari-agent/src/main/python/ambari_agent/alerts/collector.py PRE-CREATION > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 165f890 > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 51c3af9 > ambari-agent/src/test/python/ambari_agent/dummy_files/alert_definitions.def > PRE-CREATION > > ambari-agent/src/test/python/ambari_agent/dummy_files/alert_definitions.json > 6c55966 > > Diff: https://reviews.apache.org/r/24893/diff/ > > > Testing > ------- > > Agent tests only, and verification on a dev cluster > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 10.081s > [INFO] Finished at: Wed Aug 20 10:38:06 EDT 2014 > [INFO] Final Memory: 7M/81M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
