-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24933/#review51236
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Aug. 21, 2014, 1:30 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24933/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 1:30 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-6976
>     https://issues.apache.org/jira/browse/AMBARI-6976
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Alert definitions are merged into the database from the stack based on the 
> services that are installed on the cluster at startup time; if there are no 
> clusters, then nothing is merged.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  2eec33bf10b329ef5e0da6dcc26eb66a28533a37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  489fbb22fce1df611ebb75595f13fbc7361ab9a8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  1417bdbdf59121cdef1c4447681a36c84011cbcd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
>  db5c63f69e05b30bdfa0a72295dc268b917a3b79 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateSource.java
>  d056c408d8a600873e73c0bd556a1e1482f9db1a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
>  15f4bfed858eb8a886e0cad953eb8b1f711dfb5f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
>  5ddb521c83946867d50e01c8420398867499d5fb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
>  9ad4a1303265d97e6bb2d1e17b92bf11dfd17ec7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PercentSource.java
>  ef79cfd71aa9e5841809517fbd30feb3f5e98e5f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java
>  afb60dd3aad057af17e45ba0f29450de469d9e8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  7e63d439d750c5544dd8303217aa64061111f4fa 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/Scope.java 
> 4b06b6294569169b62b814c88290282b8d9bc8ca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java
>  13a60578b7603dc1bbaf0cd35501e04543508d0a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Source.java 
> cdce41ccd69659d0f617ed5b77b076758e59b60e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
>  144900ef800f70db9c7b4ee81c637849660a86f2 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> fe396124e0bfc0bfb86abe251beb0cff08fd576a 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> e311646dbe42c953b851157133c1424e3cb56677 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> 25d973f1a9d3dafc1dd766e18ad09fd704f4b339 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 2d5b2678bba2ad4b1036ef6b5555105113d3b8ad 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 
> 6a06d4dbd94b08cb24fcf274276ece8b5f025b37 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  6b50e164c9abfe2bf593e7e12072ec76de708a11 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
>  61ceb7bafe733e762b5cacf6e58cbb4db5f21222 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json 
> 02a9a58617444064f45d34cbe5ae5ae8e00d904e 
> 
> Diff: https://reviews.apache.org/r/24933/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 17:49 min
> [INFO] Finished at: 2014-08-21T13:29:32-04:00
> [INFO] Final Memory: 23M/211M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Reply via email to