----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24979/#review51283 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Aug. 22, 2014, 9:30 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24979/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 9:30 a.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-6983 > https://issues.apache.org/jira/browse/AMBARI-6983 > > > Repository: ambari > > > Description > ------- > > * Made some changes from last review - adding constants for source types, > save all definitions in one file instead of one-per-cluster. > * Added substitution variables for those sources that support it. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 10fdef7 > ambari-agent/src/main/python/ambari_agent/Controller.py 23c28ae > ambari-agent/src/main/python/ambari_agent/Heartbeat.py fb41759 > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 6e99692 > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 2f051c8 > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 0d0563a > ambari-agent/src/test/python/ambari_agent/TestController.py 9ec23db > ambari-agent/src/test/python/ambari_agent/dummy_files/alert_definitions.def > 45fb8d0 > ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java > 3c9615f > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeat.java > 80cad4e > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 65b7b6f > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 5336694 > > Diff: https://reviews.apache.org/r/24979/diff/ > > > Testing > ------- > > Wanted to get this patch in before being unavailable for a week, so full test > suite not made for this patch. Verified existing tests are not broken. > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 5.748s > [INFO] Finished at: Fri Aug 22 09:29:41 EDT 2014 > [INFO] Final Memory: 7M/81M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
