----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24993/#review51348 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Aug. 23, 2014, 2:02 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24993/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2014, 2:02 p.m.) > > > Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Sid Wagle. > > > Bugs: AMBARI-6995 > https://issues.apache.org/jira/browse/AMBARI-6995 > > > Repository: ambari > > > Description > ------- > > If a new view instance is added, the user should be able to access the UI for > that instance without having to restart Ambari server. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 07de5cb > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 2513382 > > ambari-server/src/main/java/org/apache/ambari/server/controller/FailsafeHandlerList.java > 48ec626 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > 75b0879 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > 643bac2 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceHandlerList.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 56a3168 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > ed3a6a9 > > Diff: https://reviews.apache.org/r/24993/diff/ > > > Testing > ------- > > Manual tests. > > New unit tests added. All existing tests pass ... > > Results : > > Tests run: 1937, Failures: 0, Errors: 0, Skipped: 15 > > … > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:24.014s > [INFO] Finished at: Fri Aug 22 16:02:02 EDT 2014 > [INFO] Final Memory: 21M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
