> On Aug. 26, 2014, 3:08 p.m., John Speidel wrote: > > Ship It!
Thanks for the review! - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25011/#review51528 ----------------------------------------------------------- On Aug. 25, 2014, 1:16 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25011/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2014, 1:16 a.m.) > > > Review request for Ambari, John Speidel, Mahadev Konar, and Sumit Mohanty. > > > Bugs: AMBARI-7002 > https://issues.apache.org/jira/browse/AMBARI-7002 > > > Repository: ambari > > > Description > ------- > > Creating instance for a view should respond with 409 conflict if that > instance already exists. > > Sorry initial diff was wrong file... should be good now. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > 75b0879 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 56a3168 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java > 52f0231 > > Diff: https://reviews.apache.org/r/25011/diff/ > > > Testing > ------- > > Manual tests. > > Added new unit tests. All existing tests pass. > > > Results : > > Tests run: 1937, Failures: 0, Errors: 0, Skipped: 15 > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 25:27.078s > [INFO] Finished at: Sat Aug 23 09:20:44 EDT 2014 > [INFO] Final Memory: 21M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
