----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25032/#review51656 -----------------------------------------------------------
Ship it! Ship It! - John Speidel On Aug. 27, 2014, 2:09 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25032/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 2:09 p.m.) > > > Review request for Ambari, John Speidel, Mahadev Konar, and Sid Wagle. > > > Bugs: AMBARI-7004 > https://issues.apache.org/jira/browse/AMBARI-7004 > > > Repository: ambari > > > Description > ------- > > > Currently we can add view event listeners, but not remove them. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java > d36ad6e > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 7542876 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > 55dca84 > ambari-views/src/main/java/org/apache/ambari/view/ViewController.java > d182de0 > > Diff: https://reviews.apache.org/r/25032/diff/ > > > Testing > ------- > > New tests added. All existing tests pass. > > > Results : > > Tests run: 1935, Failures: 0, Errors: 0, Skipped: 15 > > ... > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 34:04.932s > [INFO] Finished at: Mon Aug 25 14:01:07 EDT 2014 > [INFO] Final Memory: 37M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
