-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25139/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-7051
https://issues.apache.org/jira/browse/AMBARI-7051
Repository: ambari
Description
-------
The alert group endpoint was changed to allow creating associations with
targets and definitions. Through either the PUT or POST operations, alert
definitions and alert targets can be added or removed from an alert group.
The returned data when quering the alert group was also updated to include
information about the targets and definitions. When querying a collection,
basic information such as name and ID are returned. More detailed information
is returned on querying an individual group.
The python scripts were also updated to change the get_host_from_url method to
be a static member of BaseAlert. It now returns None if only a port is
supplied. PortAlert checks for this None value and uses self.host_name as the
name of the host.
See
https://issues.apache.org/jira/browse/AMBARI-7021
https://issues.apache.org/jira/browse/AMBARI-7051
for JSON examples.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py
88c7f92afae6a8d39eae4ab44c89e9aa2e410cdd
ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py
eaf744a9ae14e45e3ba21aab1e34e864af91c82e
ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertGroupService.java
c2e5048823579dd689d565cd2fc688add08f9c6e
ambari-server/src/main/java/org/apache/ambari/server/controller/AlertDefinitionResponse.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
f14e76f04b8fd376ab63bea1de7caa1475927b05
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
4a8fe126b4392cd8b7ae47cbcc2588bbd826a366
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
dfbe747e880e0a1247d526a94c7c3a305c731c90
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
299467c87d098adbd8a922e2b95925f44c64d44f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
1ca592c87669853acf05764be0893526876b7233
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java
89728e5b34d92b52c82c5ded2ae06e443a4e6ce7
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertTarget.java
21e83d9a20d1dac03055fb1e7ced8707ee905907
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java
c9428b7f37bf798f5fff4832389d1e6d76f8fc3b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java
982dd4b1826fc0788424a1d6e13cc0189351c2ce
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java
a7ef51306d5fb871c29d43779fbb9c8b0d8a6aa5
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
894f2c27477b04b43f211b7a1a5ce66b9cccc1ee
Diff: https://reviews.apache.org/r/25139/diff/
Testing
-------
New tests added to cover added functionality.
$ mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:46 min
[INFO] Finished at: 2014-08-27T21:25:40-04:00
[INFO] Final Memory: 21M/204M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
