-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25150/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-7056
    https://issues.apache.org/jira/browse/AMBARI-7056


Repository: ambari


Description
-------

Ambari agent presumes that hadoop-env.sh file will be always available and so
puts cluster specific properties like smokeuser and kerberos_domain in hadoop-
env.sh file. These properties are used in shared initialization file for
before-INSTALL and before-ANY hooks.

Ambari should manage a separate file (cluster-env file) that carries cluster
specific properties.

    
    
    
    <configuration>
        <property>
            <name>security_enabled</name>
            <value>false</value>
            <description>Hadoop Security</description>
        </property>
        <property>
            <name>kerberos_domain</name>
            <value>EXAMPLE.COM</value>
            <description>Kerberos realm.</description>
        </property>
        <property>
            <name>ignore_groupsusers_create</name>
            <value>false</value>
            <description>Whether to ignores failures on users and group 
creation</description>
        </property>
        <property>
            <name>smokeuser</name>
            <value>ambari-qa</value>
            <description>User executing service checks</description>
        </property>
        <property>
            <name>user_group</name>
            <value>hadoop</value>
            <description>Proxy user group.</description>
        </property>
    </configuration>
    
    


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 
261559a 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 13fff1d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackLevelConfigurationResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java
 d641e4c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 56b866d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
 822199c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
 fb3ddc9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 bee118e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 c6b2f9f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java
 84105fc 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 71ddc8d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java
 9cef695 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 b10b4bc 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
de70620 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
cc1a45e 
  ambari-server/src/main/resources/key_properties.json 06ebb61 
  ambari-server/src/main/resources/properties.json 785bd24 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/configuration/cluster-env.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java
 5596a1e 
  
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java
 3a62147 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java
 c1f4f5b 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/25150/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Reply via email to