-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25256/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-7115
    https://issues.apache.org/jira/browse/AMBARI-7115


Repository: ambari


Description
-------

Following files has service specific references.

  1. hooks->BEFORE-INSTALL->shared_initialization.py
  2. hooks->BEFORE-START->shared_initialization.py

hooks->BEFORE-INSTALL->shared_initialization.py file is required to change
while adding a new service package because user creation logic for a service
resides in the hooks folder.

Any tasks that needs to be done before installing or starting a service should
be implemented in a service package.

**On accomplishing this ticket, It will be possible to plug a new service 
definition into a deployed cluster without changing any existing python code.**


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 33c5af4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 efce9bd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
 96ca232 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
 7229197 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 2cf01ff 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 e5b6016 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
 eeee694 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
 2e2bfe1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
 116f589 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
 7926fd4 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
43838d7 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
6a17e9d 
  ambari-server/src/main/resources/properties.json 741ffe6 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/configuration/cluster-env.xml 
a2df35a 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py
 2bcbd50 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py
 f556335 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/configuration/ganglia-env.xml
 68d94f2 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-env.xml
 d02ec1b 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-env.xml
 ba704ba 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py
 58f01f8 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-env.xml
 252aa81 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml
 fabcdf3 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-env.xml
 2553025 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/configuration/nagios-env.xml
 54c742c 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-env.xml
 4585f29 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml
 ae22d5d 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/SQOOP/configuration/sqoop-env.xml
 f1753c6 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/zookeeper-env.xml
 33e9cef 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
a2df35a 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py
 f76cc33 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
 0542a3e 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/configuration/flume-env.xml
 43cea5f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/configuration/ganglia-env.xml
 d340a94 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-env.xml
 6d27511 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hadoop-env.xml
 573a67c 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py
 5c2f792 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-env.xml
 8c17086 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml
 35758fe 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/nagios-env.xml
 54c742c 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-env.xml
 b1f9090 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml
 632d606 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/configuration/sqoop-env.xml
 d1d56ff 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-env.xml
 f0b0ea6 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-env.xml
 184aff1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/zookeeper-env.xml
 33e9cef 
  
ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/HIVE/configuration/hive-site.xml
 36c6985 
  
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-env.xml
 8a4eabf 
  
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
 ae874e2 
  
ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/configuration/storm-env.xml
 2e118d1 
  
ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/configuration/tez-env.xml
 992a4df 
  
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-env.xml
 4f9b39a 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 c08534c 
  
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java
 c7af864 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
 06d8bb7 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintEntityTest.java
 de104e7 
  
ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml
 470f341 

Diff: https://reviews.apache.org/r/25256/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Reply via email to