> On Sept. 5, 2014, 6:07 a.m., Tom Beerbower wrote: > > ambari-server/src/main/resources/key_properties.json, lines 148-153 > > <https://reviews.apache.org/r/25362/diff/1/?file=679068#file679068line148> > > > > Any issues using a single Alert resource type since it can have > > different owning resources? I guess for a service Alert the > > Alert/host_name key property is just null?
Thanks for reviewing! It felt right to have it as only one resource, and you are correct - a service alert can have a null hostname. > On Sept. 5, 2014, 6:07 a.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertResourceDefinition.java, > > lines 31-39 > > <https://reviews.apache.org/r/25362/diff/1/?file=679053#file679053line31> > > > > Can you add a TODO in the code saying that these will be changed to > > "alerts" and "alert" just so it's clear to anyone reading the code that > > these names are just placeholders? By the time the code gets merged back to trunk this will be resolved (only 2 people working on it :) ). - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25362/#review52435 ----------------------------------------------------------- On Sept. 4, 2014, 7:49 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25362/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2014, 7:49 p.m.) > > > Review request for Ambari, Jonathan Hurley and Tom Beerbower. > > > Bugs: AMBARI-7160 > https://issues.apache.org/jira/browse/AMBARI-7160 > > > Repository: ambari > > > Description > ------- > > Initial cut at creating endpoints for alert data at cluster, service, and > host level. > * Names are not the final ones, that will be in a separate jira (we have an > attribute already called 'alerts' - those are out of Nagios) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java > 702bcf8 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java > 8aba287 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > ffbfb29 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java > e1355ad > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java > 3f1ce36 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > db9d3c0 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java > 643ae36 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c75a7bb > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 31c350b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > 2cf6d99 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java > b43b5b1 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java > 31b1673 > ambari-server/src/main/resources/key_properties.json db34920 > ambari-server/src/main/resources/properties.json accab44 > > ambari-server/src/test/java/org/apache/ambari/server/api/query/render/DefaultRendererTest.java > eb0f28f > > ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java > 16cbb2a > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java > eabb5ab > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java > 4500c1c > > Diff: https://reviews.apache.org/r/25362/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:30.862s > [INFO] Finished at: Thu Sep 04 19:14:56 EDT 2014 > [INFO] Final Memory: 26M/218M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
