----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25421/#review52589 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Sept. 7, 2014, 5:15 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25421/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2014, 5:15 p.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-7191 > https://issues.apache.org/jira/browse/AMBARI-7191 > > > Repository: ambari > > > Description > ------- > > * Renamed the existing 'alerts' attribute in the target response to > 'legacy_alerts' > * Renamed 'alerts_data' to 'alerts' as this makes more sense. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertResourceDefinition.java > afdbcfc > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertService.java > 8e163c2 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java > c76acf7 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > 8cec7e1 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java > 30f4f2f > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 73e4013 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > fc60210 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertSummaryPropertyProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java > d2e425f > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertSummaryDTO.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java > 5fcc1ec > > ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java > 4316dc9 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java > 7c206a2 > ambari-web/app/controllers/global/update_controller.js a71f689 > ambari-web/app/controllers/main/alerts_controller.js 0ea7212 > ambari-web/app/controllers/main/host.js 227a091 > ambari-web/app/mappers/hosts_mapper.js 05037f2 > ambari-web/app/mappers/service_mapper.js 00680a3 > ambari-web/app/utils/ajax/ajax.js 3d1fda9 > ambari-web/test/controllers/main/alerts_controller_test.js 3a3dc7f > > Diff: https://reviews.apache.org/r/25421/diff/ > > > Testing > ------- > > ambari-server: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:20.887s > [INFO] Finished at: Sun Sep 07 17:15:28 EDT 2014 > [INFO] Final Memory: 28M/229M > [INFO] > ------------------------------------------------------------------------ > > > ambari-web: > Manual testing, plus unit tests > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 16.614s > [INFO] Finished at: Sun Sep 07 17:02:56 EDT 2014 > [INFO] Final Memory: 6M/81M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
