----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25538/#review53033 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/providers/execute_hadoop.py <https://reviews.apache.org/r/25538/#comment92380> This export makes our command a bit messy / hard to read can we do something like this: params.py: hadop_path = os.environ['PATH']+os.pathsep+bin_dir other_script.py: Execute(... environment = {'PATH':hadop_path} ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py <https://reviews.apache.org/r/25538/#comment92381> For HDfsDirectory we can put this to params partial function definition. ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py <https://reviews.apache.org/r/25538/#comment92382> Does the create action really needs that information? ambari-server/src/main/resources/stacks/HDP/2.2/repos/repoinfo.xml <https://reviews.apache.org/r/25538/#comment92383> I see that this is not used for the new, stack. I think for now it's better to remove this not to create confusion. ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml <https://reviews.apache.org/r/25538/#comment92384> This change should brake brueprints. Cause we are loosing all the other properties from hadoop-env.xml from parent stack. We should duplicate them as well (not just add new one). You can check that via stacks API. ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-site.xml <https://reviews.apache.org/r/25538/#comment92385> the same for all service configurations which was changed. ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/metainfo.xml <https://reviews.apache.org/r/25538/#comment92386> Why we have so much duplication here, can we remove some things which are inhereted? ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/metainfo.xml <https://reviews.apache.org/r/25538/#comment92387> I also don't see changed package name for Hcatalog. Do we need that? ambari-server/src/main/resources/stacks/HDP/2.2/services/WEBHCAT/configuration/webhcat-env.xml <https://reviews.apache.org/r/25538/#comment92389> Also we can get rid redifing this as we talked. ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/metainfo.xml <https://reviews.apache.org/r/25538/#comment92388> Again, let's get reed of duplication in this file as well. - Andrew Onischuk On Sept. 11, 2014, 1:34 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25538/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 1:34 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-7257 > https://issues.apache.org/jira/browse/AMBARI-7257 > > > Repository: ambari > > > Description > ------- > > Use Versioned RPMS for HDP 2.2 stack and make it plugabable to be able to > reuse the scripts for HDP 2.* > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/core/providers/system.py > c297c83 > > ambari-common/src/main/python/resource_management/libraries/providers/execute_hadoop.py > 8ab71ff > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py > 6a40b6d > > ambari-common/src/main/python/resource_management/libraries/resources/execute_hadoop.py > 94daf5b > > ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py > 63d9cc2 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py > d537199 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py > 01789a7 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > 720777f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/files/checkForFormat.sh > f92f613 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > fc525a6 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py > 6109d3e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_check.py > 3036e20 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py > 128eed4 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/files/hbaseSmokeVerify.sh > eedffd3 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py > 2829c7b > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py > 364649c > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/service_check.py > 8fb38f7 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/checkForFormat.sh > d22d901 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py > c4b48c6 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py > 8dae3eb > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py > 47ee8ca > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/service_check.py > 66f2ae1 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hcat.py > 53a62ce > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hcat_service_check.py > ec8faa9 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py > 0b7fcb4 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_service.py > 8507816 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/install_jars.py > b6d542d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py > b1a4a49 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/startHiveserver2.sh.j2 > a8fe21c > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-env.xml > fc47a70 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/files/oozieSmoke2.sh > 0a80d0f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py > d390c69 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie_service.py > 78661b0 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py > a484c0e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py > 1b522b8 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py > 8431b6d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py > 144a587 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py > a7959f0 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/webhcat.py > 3092735 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py > 313ed94 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py > af678d0 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service.py > 42a7138 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service_check.py > 2ed67ab > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py > 6aff622 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py > 2dc3792 > > ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/falcon.py > 880e2d4 > > ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/params.py > 7a61c8a > > ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/params.py > 19668c7 > ambari-server/src/main/resources/stacks/HDP/2.2/metainfo.xml PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/repos/repoinfo.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/FLUME/metainfo.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-site.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/configuration/oozie-site.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/metainfo.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-site.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/metainfo.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/WEBHCAT/configuration/webhcat-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/WEBHCAT/configuration/webhcat-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/WEBHCAT/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration-mapred/mapred-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/ZOOKEEPER/metainfo.xml > PRE-CREATION > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_service_check.py > 78cfde7 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > c820120 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py > 6a97941 > > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_service_check.py > 7f9bfa4 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 5e38f66 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py > 78cfde7 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hcat_client.py 6da9d2f > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py > 0bef64d > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 1c7e47e > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > eefb6b9 > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py > 1b98e45 > ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py > 1e1ad24 > ambari-server/src/test/python/stacks/2.0.6/WEBHCAT/test_webhcat_server.py > 0e96b66 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > 155e07d > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 4723b0f > ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py > 7c4c01a > ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py > 93ea2d1 > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py > 77909a7 > > Diff: https://reviews.apache.org/r/25538/diff/ > > > Testing > ------- > > OK > ---------------------------------------------------------------------- > Total run:614 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmytro Sen > >
