> On Sept. 11, 2014, 6:10 p.m., Alejandro Fernandez wrote: > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderBaseTest.java, > > line 37 > > <https://reviews.apache.org/r/25547/diff/1/?file=685939#file685939line37> > > > > Just nitpicking here, but the indendation looks off.
That's ugly. Will fix it. - jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25547/#review53069 ----------------------------------------------------------- On Sept. 11, 2014, 5:57 p.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25547/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 5:57 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-7180 > https://issues.apache.org/jira/browse/AMBARI-7180 > > > Repository: ambari > > > Description > ------- > > Some part of my previous comment are parsed wrong in html format. reposting. > 1. Let ApacheDSContainer to create a test specific folder > {job_root}/target/timestamp/apacheds-spring-security > instead of the default > /tmp/apacheds-spring-security > 2. and Delete the folder if exists > > > Diffs > ----- > > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderBaseTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDNWithSpaceTest.java > ae8054b > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java > 2a2d3dd > > Diff: https://reviews.apache.org/r/25547/diff/ > > > Testing > ------- > > > Thanks, > > jun aoki > >
