-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25579/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-7278
    https://issues.apache.org/jira/browse/AMBARI-7278


Repository: ambari


Description
-------

1) Install cluster with default settings and all components at all nodes
2) Do upgrade to 1.7.0
3) Reconfig services (add some configs)
{code}
<configuration name="custom_properties_for_reconfiguration_test">
    <service name="HDFS">
        <group name="Custom core-site">
        <property>
                <label>test-reconfigure-core-site</label>
                <name>test-reconfigure-core-site</name>
                <value>test-reconfigure-core-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/hadoop/conf/core-site.xml</file>
            </property>
        </group>
        <group name="Custom hdfs-site">
        <property>
                <label>test-reconfigure-hdfs-site</label>
                <name>test-reconfigure-hdfs-site</name>
                <value>test-reconfigure-hdfs-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/hadoop/conf/hdfs-site.xml</file>
            </property>
        </group>
    </service>    
    <service name="MAPREDUCE2">
        <group name="Custom mapred-site">
        <property>
                <label>test-reconfigure-mapred-site</label>
                <name>test-reconfigure-mapred-site</name>
                <value>test-reconfigure-mapred-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/hadoop/conf/mapred-site.xml</file>
            </property>
        </group>
    </service>
    <service name="YARN">
        <group name="Custom yarn-site">
        <property>
                <label>test-reconfigure-yarn-site</label>
                <name>test-reconfigure-yarn-site</name>
                <value>test-reconfigure-yarn-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/hadoop/conf/yarn-site.xml</file>
            </property>
        </group>
    </service>
    <service name="TEZ">
        <group name="Custom tez-site">
        <property>
                <label>reconfigure-test-tez-site</label>
                <name>reconfigure-test-tez-site</name>
                <value>reconfigure-test-tez-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/tez/conf/tez-site.xml</file>
            </property>
        </group>
    </service>
    <service name="HIVE">
        <group name="Custom hive-site">
        <property>
                <label>test-reconfigure-hive-site</label>
                <name>test-reconfigure-hive-site</name>
                <value>test-reconfigure-hive-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/hive/conf/hive-site.xml</file>
            </property>
        </group>
    </service>
    <service name="WEBHCAT">
        <group name="Custom webhcat-site">
        <property>
                <label>test-reconfigure-webhcat-site</label>
                <name>test-reconfigure-webhcat-site</name>
                <value>test-reconfigure-webhcat-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/hive-webhcat/conf/webhcat-site.xml</file>
            </property>
        </group>
    </service>
    <service name="HBASE">
        <group name="Custom hbase-site">
        <property>
                <label>test-reconfigure-hbase-site</label>
                <name>test-reconfigure-hbase-site</name>
                <value>test-reconfigure-hbase-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/hbase/conf/hbase-site.xml</file>
            </property>
        </group>
    </service>
    <service name="OOZIE">
        <group name="Custom oozie-site">
        <property>
                <label>test-reconfigure-oozie-site</label>
                <name>test-reconfigure-oozie-site</name>
                <value>test-reconfigure-oozie-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/oozie/conf/oozie-site.xml</file>
            </property>
        </group>
    </service>
    <service name="STORM">
        <group name="Custom storm-site">
        <property>
                <label>test-reconfigure-storm-site</label>
                <name>test-reconfigure-storm-site</name>
                <value>test-reconfigure-storm-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/storm/conf/storm.yaml</file>
            </property>
        </group>
    </service>
    <service name="FALCON">
        <group name="Custom falcon-startup.properties">
        <property>
                <label>test-reconfigure-falcon-startup-site</label>
                <name>test-reconfigure-falcon-startup-site</name>
                <value>test-reconfigure-falcon-startup-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/falcon/conf/startup.properties</file>
            </property>
        </group>
        <group name="Custom falcon-runtime.properties">
        <property>
                <label>test-reconfigure-falcon-runtime-site</label>
                <name>test-reconfigure-falcon-runtime-site</name>
                <value>test-reconfigure-falcon-runtime-site-VALUE</value>
                <type>INPUT</type>
                <file>/etc/falcon/conf/runtime.properties</file>
            </property>
        </group>
    </service>
</configuration>
{code}
3.b)Stop/Start  all services
4)Go on oozie/Hive->Configs tab

Actual result:
Configs are not loaded after reconfig.

Expected result:
Configs are loaded after reconfig.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
 0e8aea5 

Diff: https://reviews.apache.org/r/25579/diff/


Testing
-------

mvn test clean


Thanks,

Vitalyi Brodetskyi

Reply via email to