----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25638/#review53327 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Sept. 15, 2014, 11:30 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25638/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 11:30 a.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-7304 > https://issues.apache.org/jira/browse/AMBARI-7304 > > > Repository: ambari > > > Description > ------- > > This fails due to not-mocked pythonpath, we should mock that for stack tests > as well it can be even done in RMFTestCase.py like it is done for os_type, > shell_mock now. > > {noformat} > ====================================================================== > FAIL: test_run_command_list > (TestExecuteHadoopResource.TestExecuteHadoopResource) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/user/ambari/ambari-common/src/test/python/mock/mock.py", line > 1199, in patched > return func(*args, **keywargs) > File > "/home/user/ambari/ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py", > line 108, in test_run_command_list > {'logoutput': False, 'tries': 1, 'user': 'user', 'try_sleep': 0}) > AssertionError: {'environment': {'PATH': > '/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/u [truncated]... != > {'logoutput': False, 'tries': 1, 'user': 'user', 'try_sleep': 0} > + {'logoutput': False, 'tries': 1, 'try_sleep': 0, 'user': 'user'} > - {'environment': {'PATH': > '/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/user/bin:/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/user/bin:/usr/lib/lightdm/lightdm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games'}, > - 'logoutput': False, > - 'tries': 1, > - 'try_sleep': 0, > - 'user': 'user'} > > ====================================================================== > FAIL: test_run_default_args > (TestExecuteHadoopResource.TestExecuteHadoopResource) > ---------------------------------------------------------------------- > Traceback (most recent call last): > > File "/home/user/ambari/ambari-common/src/test/python/mock/mock.py", line > 1199, in patched > return func(*args, **keywargs) > File > "/home/user/ambari/ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py", > line 41, in test_run_default_args > {'logoutput': True, 'tries': 1, 'user': 'user', 'try_sleep': 0}) > AssertionError: {'environment': {'PATH': > '/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/u [truncated]... != > {'logoutput': True, 'tries': 1, 'user': 'user', 'try_sleep': 0} > + {'logoutput': True, 'tries': 1, 'try_sleep': 0, 'user': 'user'} > - {'environment': {'PATH': > '/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/user/bin:/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/user/bin:/usr/lib/lightdm/lightdm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games'}, > - 'logoutput': True, > - 'tries': 1, > - 'try_sleep': 0, > - 'user': 'user'} > > ====================================================================== > FAIL: test_run_defined_args > (TestExecuteHadoopResource.TestExecuteHadoopResource) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/user/ambari/ambari-common/src/test/python/mock/mock.py", line > 1199, in patched > return func(*args, **keywargs) > File > "/home/user/ambari/ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py", > line 86, in test_run_defined_args > {'logoutput': True, 'tries': 2, 'user': 'user', 'try_sleep': 2}) > AssertionError: {'environment': {'PATH': > '/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/u [truncated]... != > {'logoutput': True, 'tries': 2, 'user': 'user', 'try_sleep': 2} > + {'logoutput': True, 'tries': 2, 'try_sleep': 2, 'user': 'user'} > - {'environment': {'PATH': > '/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/user/bin:/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/user/bin:/usr/lib/lightdm/lightdm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games'}, > - 'logoutput': True, > - 'tries': 2, > - 'try_sleep': 2, > - 'user': 'user'} > > ====================================================================== > FAIL: test_run_secured (TestExecuteHadoopResource.TestExecuteHadoopResource) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/user/ambari/ambari-common/src/test/python/mock/mock.py", line > 1199, in patched > return func(*args, **keywargs) > File > "/home/user/ambari/ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py", > line 159, in test_run_secured > {'logoutput': True, 'tries': 1, 'user': 'user', 'try_sleep': 0}) > AssertionError: {'environment': {'PATH': > '/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/u [truncated]... != > {'logoutput': True, 'tries': 1, 'user': 'user', 'try_sleep': 0} > + {'logoutput': True, 'tries': 1, 'try_sleep': 0, 'user': 'user'} > - {'environment': {'PATH': > '/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/user/bin:/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/user/bin:/usr/lib/lightdm/lightdm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games'}, > - 'logoutput': True, > - 'tries': 1, > - 'try_sleep': 0, > - 'user': 'user'} > > ====================================================================== > FAIL: test_run_unknown_conf > (TestExecuteHadoopResource.TestExecuteHadoopResource) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/user/ambari/ambari-common/src/test/python/mock/mock.py", line > 1199, in patched > return func(*args, **keywargs) > File > "/home/user/ambari/ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py", > line 61, in test_run_unknown_conf > {'logoutput': False, 'tries': 1, 'user': 'user', 'try_sleep': 0}) > AssertionError: {'environment': {'PATH': > '/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/u [truncated]... != > {'logoutput': False, 'tries': 1, 'user': 'user', 'try_sleep': 0} > + {'logoutput': False, 'tries': 1, 'try_sleep': 0, 'user': 'user'} > - {'environment': {'PATH': > '/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/user/bin:/home/user/bin:/usr/local/java/jdk1.7.0_51/bin:/home/user/bin:/usr/lib/lightdm/lightdm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games'}, > - 'logoutput': False, > - 'tries': 1, > - 'try_sleep': 0, > - 'user': 'user'} > {noformat} > > > Diffs > ----- > > > ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py > e357390 > > Diff: https://reviews.apache.org/r/25638/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 299 tests in 5.138s > > OK > > > Thanks, > > Dmytro Sen > >
