----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25224/#review53690 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On Sept. 1, 2014, 11:31 a.m., Krisztian Horvath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25224/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2014, 11:31 a.m.) > > > Review request for Ambari and Yusaku Sako. > > > Bugs: AMBARI-6040 > https://issues.apache.org/jira/browse/AMBARI-6040 > > > Repository: ambari > > > Description > ------- > > new commands: > configuration show --type core-site | prints the selected configuration > (config types are TAB completed/no typing) > configuration modify --type core-site --key fs.trash.interval --value 300 | > modifies a single property of a config > configuration set --type core-site --url > https://gist.githubusercontent.com/keyki/f102313f2ca8b5bfada4/raw/core-site.xml > | sets the configuration to the desired > configuration set --type core-site --file core-site.xml | sets the > configuration to the desired > configuration download --type core-site | downloads the selected config as XML > > > Diffs > ----- > > > ambari-client/groovy-client/src/main/groovy/org/apache/ambari/groovy/client/AmbariClient.groovy > f0ca650 > ambari-shell/ambari-groovy-shell/pom.xml a1acf8b > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/commands/ConfigCommands.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/completion/AbstractCompletion.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/completion/Blueprint.java > 4eec7b1 > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/completion/ConfigType.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/completion/Host.java > f64e97b > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/completion/Service.java > bbbf37c > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/configuration/ConverterConfiguration.java > c19aced > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/converter/AbstractConverter.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/converter/BlueprintConverter.java > 7984e7f > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/converter/ConfigTypeConverter.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/converter/HostConverter.java > 39aa6e9 > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/converter/ServiceConverter.java > e7f9d2c > > ambari-shell/ambari-groovy-shell/src/test/java/org/apache/ambari/shell/commands/ConfigCommandsTest.java > PRE-CREATION > ambari-shell/ambari-groovy-shell/src/test/resources/core-site.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/25224/diff/ > > > Testing > ------- > > unit tests applied > > > Thanks, > > Krisztian Horvath > >
