-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25787/
-----------------------------------------------------------
(Updated Sept. 18, 2014, 3:22 p.m.)
Review request for Ambari and Nate Cole.
Changes
-------
Fixed tabbing and interface naming. I really, really miss IFoo
Bugs: AMBARI-7391
https://issues.apache.org/jira/browse/AMBARI-7391
Repository: ambari
Description
-------
- Using a Guava service to scan for PENDING alert notices
- Aggregating alert notices and then building a notification to pass to a
dispatcher
- Generic dispatcher framework for handling notifications
- Updating alert notices after dispatch for either DELIVERED or FAILED
Notification is not yet complete
Dispatching is done using singletons, factories, and callbacks
Diffs (updated)
-----
ambari-server/pom.xml b07afbfbd7a0fa38c994a93af91375280cf8fda2
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
735470635e66243ec602a806c633e3ddf6adf56d
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
349e46514ee38decdc8f6f10f1ed021343a0166d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java
519ceeb3b056678566f16a11a4996a79d3cb1b79
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertServiceStateListener.java
906d52d6273e082ce6ad69d3e1aebc5a559eebf5
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertStateChangedListener.java
ac22f881627e2211d4c5d2edff5d7b4102b33838
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/AlertEventPublisher.java
f1a0b3ebe07d682ce0519070daca2ee35506c8b5
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCallback.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchRunnable.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
f410c39afc2fbc953749720f1985d4f01556f265
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
6d4d19be8aa16888666cb59eaccb504457c4bfa4
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java
8db89f75f485e68a5a01ae6e0a5dcf1ed8042fe8
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
e7fa9c6e52a135877b9124f493575ddf5c66e8b6
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java
c9470ce6bdd564524338071e17ea74d0e5b556c7
ambari-server/src/main/java/org/apache/ambari/server/state/alert/TargetType.java
e2564cc1d639de1f921c4275b06414c31f75ae1c
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
d938771bf433f518e44ab6945c8c0a03832ec780
ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java
526104f162ac73c2d0f0fb8320531eb968c247da
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java
f7deef56c7703c523db2b3f227da157344866689
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
11039612bf7a0e1e78785d4307e8ef8f46e30952
Diff: https://reviews.apache.org/r/25787/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
