----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26038/#review54542 -----------------------------------------------------------
Ship it! Ship It! - Myroslav Papirkovskyy On Вер. 25, 2014, 5:55 після полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26038/ > ----------------------------------------------------------- > > (Updated Вер. 25, 2014, 5:55 після полудня) > > > Review request for Ambari and Myroslav Papirkovskyy. > > > Bugs: AMBARI-7488 > https://issues.apache.org/jira/browse/AMBARI-7488 > > > Repository: ambari > > > Description > ------- > > For now, when we trying to execute dbAccessor.setNullable(...) for Mysql, we > will get exception(syntax error). For MySQL, setNullable action should be > changed. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java > be18970 > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java > 8586273 > > ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java > 52eac62 > > ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DerbyHelper.java > 5f39509 > > ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/GenericDbmsHelper.java > a273265 > > ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/MySqlHelper.java > 841a854 > > ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/OracleHelper.java > 4da8e8f > > ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/PostgresHelper.java > c3ad9c5 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java > 7e7738c > > ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java > 8abadea > > Diff: https://reviews.apache.org/r/26038/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
