[ 
https://issues.apache.org/jira/browse/AMBARI-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148500#comment-14148500
 ] 

Hudson commented on AMBARI-7464:
--------------------------------

FAILURE: Integrated in Ambari-trunk-Commit #380 (See 
[https://builds.apache.org/job/Ambari-trunk-Commit/380/])
AMBARI-7464. Make stack_advisor code more human readable - additional changes 
(srimanth) (sgunturi: 
http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=fcdade6b56becd000f78d85889191bb90c3c6cd0)
* ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py
* ambari-server/.pydevproject


> Make stack_advisor code more human readable
> -------------------------------------------
>
>                 Key: AMBARI-7464
>                 URL: https://issues.apache.org/jira/browse/AMBARI-7464
>             Project: Ambari
>          Issue Type: Task
>          Components: stacks
>    Affects Versions: 1.7.0
>            Reporter: Srimanth Gunturi
>            Assignee: Srimanth Gunturi
>             Fix For: 1.7.0
>
>         Attachments: AMBARI-7464.patch, AMBARI-7464_2.patch
>
>
> The stack_advisor.py files are very important for the stack, and are files 
> that we expect stack-providers to read and understand. To help users and 
> admins to read and understand, we have to put documentation on every main 
> method, and provide the structure of the input and output. Also, the method 
> names should express what the method does, and for what purpose.
> So in this change, we should see method renames and documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to