----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26135/#review54812 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Sept. 29, 2014, 9:14 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26135/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 9:14 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-7537 > https://issues.apache.org/jira/browse/AMBARI-7537 > > > Repository: ambari > > > Description > ------- > > In the case where group membership is defined by an attribute like this ... > > {code} > uniqueMember > uid=tesla,dc=example,dc=com > uid=newton,dc=example,dc=com > ... > {code} > > The code assumes that the attribute value will be a simple, single value like > 'tesla' or 'newton', so the filter is not constructed properly for the case > above. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java > f07c6d0 > > ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java > 93a0b46 > > Diff: https://reviews.apache.org/r/26135/diff/ > > > Testing > ------- > > Manual tests. > > New unit test added. All existing tests pass ... > > Results : > > Tests run: 2076, Failures: 0, Errors: 0, Skipped: 16 > > … > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 29:14.924s > [INFO] Finished at: Mon Sep 29 06:24:54 EDT 2014 > [INFO] Final Memory: 38M/478M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
