-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26138/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-7540
https://issues.apache.org/jira/browse/AMBARI-7540
Repository: ambari
Description
-------
Initially, it was thought that alerts defined on the stack should be merged
into existing alerts in the database on server startup so that changes made to
the stack will be updated in the DB.
However, there is a problem with this approach where editing a stack-based
alert from the REST endpoints will be overwritten on the next startup. We could
track this state change in the database, but this seems like a v2 feature.
For v1, let's change the logic so that stack merging into the DB is only done
for new alerts detected in alerts.json.
Diffs
-----
ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json
8e018337bde10b3d6955f7b1daef0e6f2c2ab340
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
c15f73b062db9e61a61e5a11fcfb27d9333613e8
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json
620c89fc50911e337f4a9a5eb597780f7716e260
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
4c59a36a0b501c24df6e6d42c8152024d3b1657c
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json
0077bad944416b4440906054100e0e236cff05fc
Diff: https://reviews.apache.org/r/26138/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
