----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26065/#review54932 -----------------------------------------------------------
Ship it! Looks good to me although I'm not familiar with the code. Probably best to get additional +1. - Tom Beerbower On Sept. 29, 2014, 5:14 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26065/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 5:14 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, Mahadev Konar, Sid > Wagle, and Tom Beerbower. > > > Bugs: AMBARI-7506 > https://issues.apache.org/jira/browse/AMBARI-7506 > > > Repository: ambari > > > Description > ------- > > When a drive fails and it is unmounted for service, if the data node process > is stopped/started using Ambari the dfs.data.dir path that was housed on that > drive is re-created, but this time on the / partition leading to out of disk > space issues and data being created on the wrong volume. > In this case we only want the Ambari Agent to create dfs.data.dir's during > installation, and not after as this makes drive replacements difficult. > > > Diffs > ----- > > ambari-agent/src/test/python/resource_management/TestFileSystem.py > PRE-CREATION > ambari-common/src/main/python/resource_management/core/logger.py e395bd7 > ambari-common/src/main/python/resource_management/core/providers/mount.py > dc6d7d9 > > ambari-common/src/main/python/resource_management/libraries/functions/dfs_datanode_helper.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/functions/file_system.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-env.xml > 5da6484 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py > 2482f97 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py > 245ad92 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hadoop-env.xml > b3935d7 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py > e38d9af > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py > c56fac4 > ambari-server/src/test/python/stacks/1.3.2/configs/default.json c5c162f > ambari-server/src/test/python/stacks/1.3.2/configs/secured.json b04f6e1 > ambari-server/src/test/python/stacks/2.0.6/configs/default.json ef279b4 > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 8db2df2 > ambari-web/app/data/HDP2/site_properties.js 1d2dbb4 > ambari-web/app/data/site_properties.js 06bbe09 > > Diff: https://reviews.apache.org/r/26065/diff/ > > > Testing > ------- > > Created unit tests and simple end-to-end test on a sandbox VM. > Still need to run more thorough functional tests on a host that has multiple > drives. > > > Thanks, > > Alejandro Fernandez > >
