-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26231/
-----------------------------------------------------------
(Updated Oct. 1, 2014, 6 p.m.)
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-7496
https://issues.apache.org/jira/browse/AMBARI-7496
Repository: ambari
Description
-------
Trivial change to error message. Use viewDefinition.getName() which is the
unique view name (including version) instead of viewDefinition.getViewName()
which is just the common view name.
Description ...
I have 3 versions of a view. I deployed version 4 that has an error deploying.
The UI correctly shows me the deploy failed and to check the log.
I check the log and can see there was an error deploying the view. But it
doesn't specify which version, which would be good to know instance there are
failures of the same view, diff versions.
{code}
12:26:13,491 ERROR [pool-1-thread-1] ViewRegistry:1244 - Caught exception
loading view CAPACITY-SCHEDULER
java.lang.IllegalStateException: No property values exist for the required
parameters [ambari.server.password, something.new, ambari.server.username,
ambari.server.url]
at
org.apache.ambari.server.orm.entities.ViewInstanceEntity.validate(ViewInstanceEntity.java:753)
at
org.apache.ambari.server.view.ViewRegistry.createViewInstanceDefinition(ViewRegistry.java:858)
at
org.apache.ambari.server.view.ViewRegistry.readViewArchive(ViewRegistry.java:1224)
at
org.apache.ambari.server.view.ViewRegistry.access$000(ViewRegistry.java:97)
at
org.apache.ambari.server.view.ViewRegistry$4.run(ViewRegistry.java:1176)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
12:26:15,912 INFO [qtp1899753024-68] HeartBeatHandler:458 - State of service
compone
{code}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
5f775a6
Diff: https://reviews.apache.org/r/26231/diff/
Testing
-------
Trivial change to error message. No additional tests added.
All existing tests pass ...
Results :
Tests run: 2076, Failures: 0, Errors: 0, Skipped: 16
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33:54.461s
[INFO] Finished at: Wed Oct 01 10:21:51 EDT 2014
[INFO] Final Memory: 31M/222M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
