----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26258/#review55179 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On Oct. 2, 2014, 1:51 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26258/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 1:51 a.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-7606 > https://issues.apache.org/jira/browse/AMBARI-7606 > > > Repository: ambari > > > Description > ------- > > Need to show a green success message at the top upon successful > user/group/instance creation like: > "Created user abc." > "Created group abc." > "Created View Instance abc." > This should come with an X icon so that the user can dismiss. > Also, the username, group name, and instance name should be linked to the > corresponding edit page. > > > Diffs > ----- > > ambari-admin/src/main/resources/ui/admin-web/app/index.html b197302 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js 868dafe > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/NavbarCtrl.js > 130d6fc > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js > 47b8f6a > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js > bfe0d14 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js > 5c1d93b > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js > 4cf39af > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsCreateCtrl.js > ba35026 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js > 8164240 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js > 64b9e27 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js > 7918be0 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js > 0aaf871 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Alert.js > PRE-CREATION > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js > 87f7831 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionLoader.js > 29138d5 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js > 40c5683 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/uiAlert.js > d916fc5 > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css da79676 > > Diff: https://reviews.apache.org/r/26258/diff/ > > > Testing > ------- > > See screenshots in AMBARI-7606 > Deployed ADMIN view and performed tests of adding users, groups, users to > groups, and view instances. > > > Thanks, > > Alejandro Fernandez > >
