----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26184/#review55202 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Oct. 2, 2014, 5:37 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26184/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 5:37 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Nate Cole. > > > Bugs: AMBARI-4881 > https://issues.apache.org/jira/browse/AMBARI-4881 > > > Repository: ambari > > > Description > ------- > > Clean up a JMXPropertyProvider hacks for STORM metrics > Also include comments from <https://reviews.apache.org/r/18521> > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > fc60210 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceImpl.java > 15fb961 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java > 51c7565 > > ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java > 12f3725 > > ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java > ca016f5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsHostProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/metrics.json > 83e27d1 > ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/metrics.json > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java > 2a086ae > > ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXPropertyProviderTest.java > 24734f8 > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json > 59bec39 > > Diff: https://reviews.apache.org/r/26184/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
