----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26057/#review55298 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java <https://reviews.apache.org/r/26057/#comment95684> This is duplicated at line 488. Why not add this to, org.apache.ambari.server.api.util.StackExtensionHelper#populateServicesForStack? Anay ways its a unique map of allowed actions for a service. This code should be removed from getApplicableServices(): which deals purely with extension behavior. - Sid Wagle On Sept. 29, 2014, 8:44 p.m., Alexander Denissov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26057/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 8:44 p.m.) > > > Review request for Ambari, Mahadev Konar and Newton Alex. > > > Bugs: AMBARI-7442 > https://issues.apache.org/jira/browse/AMBARI-7442 > > > Repository: ambari > > > Description > ------- > > ServiceCheck cannot be run if there is only one stack definition in the stack > family > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java > fe6c6bc > > ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java > 74761dd > ambari-server/src/test/resources/single_stack/ABC/1.0.0/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/single_stack/ABC/1.0.0/services/HDFS/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/26057/diff/ > > > Testing > ------- > > tested the fix against a cluster > > > Thanks, > > Alexander Denissov > >
