----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26326/#review55384 -----------------------------------------------------------
Questions ... For this case, http://sever:8080/views/JOBS/version/instance/proxy?url=http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true Is the intended behavior that the impersonator will be given 'http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true'? If so, does that mean that if we want to pass other parameters to the JOBS view, they would have to come before 'url=' in the query string? In other words, this request ... http://sever:8080/views/JOBS/version/instance/proxy?foo=bar&url=http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true ... will pass the 'foo' parameter to the JOBS view endpoint. But this request ... http://sever:8080/views/JOBS/version/instance/proxy?url=http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true&foo=bar ... will pass the 'foo' parameter to the timeline endpoint. I don't know how the user could be expected to know that requirement. If the caller was to url encode the value of the url parameter, does this work either way? - Tom Beerbower On Oct. 3, 2014, 7:38 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26326/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 7:38 p.m.) > > > Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Tom Beerbower, and > Yusaku Sako. > > > Bugs: AMBARI-7641 > https://issues.apache.org/jira/browse/AMBARI-7641 > > > Repository: ambari > > > Description > ------- > > The Jobs view should only show Tez jobs. > This is a bug in Ambari after switching to the Views proxy instead of the > generic proxy. > E.g., > http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true > returns only the tez jobs, as expected > http://viewserver:8080/views/JOBS/1.0.0/instance/proxy?url=http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true > seems to interpret "&secondaryFilter=tez:true" as a parameter to the proxy > endpoint, and not as part of the string that makes up the "url" query > parameter. > > > Diffs > ----- > > > contrib/views/jobs/src/main/java/org/apache/ambari/view/jobs/ProxyServlet.java > f02844e > > Diff: https://reviews.apache.org/r/26326/diff/ > > > Testing > ------- > > Built the view and verified it works after deploying the jar file. > > > Thanks, > > Alejandro Fernandez > >
