----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26322/#review55421 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py <https://reviews.apache.org/r/26322/#comment95778> This is not a big deal, but writing "if params.log4j_props:" or even "if params.log4j_props is not None:" is more Pythonic Also, you can skip the parantheses in the "if" statement unless the clauses really require an order of precedence. ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py <https://reviews.apache.org/r/26322/#comment95779> Why use triple quoted string when it's basically a single line? - Alejandro Fernandez On Oct. 3, 2014, 7:22 p.m., rodrigo meneses wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26322/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 7:22 p.m.) > > > Review request for Ambari and jun aoki. > > > Repository: ambari > > > Description > ------- > > Support for Mahout Service with Bigtop Stack > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json > 2604b6d > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout_client.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/templates/mahout-env.sh.j2 > PRE-CREATION > > Diff: https://reviews.apache.org/r/26322/diff/ > > > Testing > ------- > > 1. Deployed Bigtop stack w/ Mahout Service > 2. Passed all Mahout smoke tests: run mahout recommenditembas command > > > Thanks, > > rodrigo meneses > >
