----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26342/#review55440 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Oct. 4, 2014, 8:56 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26342/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2014, 8:56 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-7644 > https://issues.apache.org/jira/browse/AMBARI-7644 > > > Repository: ambari > > > Description > ------- > > Don't build view's set of sub-resources before the view is completely setup. > > Issue : > > 1. Start ambari and have views deploy (in my case, this is first-time install > so it's Jobs and Slider). > 2. Jobs finishes deploying and slider is still deploying > 3. I go to create a jobs view instance and the following call fails 400 Bad > Request > > http://c6401.ambari.apache.org:8080/api/v1/views/JOBS/versions/1.0.0/instances/asd?fields=privileges%2FPrivilegeInfo,ViewInstanceInfo,resources > > {code} > { > "status" : 400, > "message" : "The properties [resources] specified in the request or > predicate are not supported for the resource type ViewInstance." > } > {code} > > Regardless if I wait for slider view to deploy or not, until I restart ambari > server, this GET call does not succeed. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinition.java > 632a6bc > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > e48c88e > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > 47bf5c3 > > Diff: https://reviews.apache.org/r/26342/diff/ > > > Testing > ------- > > Manual testing. > > New unit test added. All existing tests pass... > > Results : > > Tests run: 2076, Failures: 0, Errors: 0, Skipped: 16 > > ... > > > INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 29:37.872s > [INFO] Finished at: Sat Oct 04 08:21:53 EDT 2014 > [INFO] Final Memory: 45M/471M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
