----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26335/#review55529 -----------------------------------------------------------
Ship it! +1. Just for the record. Ambari 1.7.0 is still using 1.0-pre. For the Jobs View, we are using a newer version of Ember. - Yusaku Sako On Oct. 5, 2014, 9:52 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26335/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2014, 9:52 p.m.) > > > Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, jun aoki, > Srimanth Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-7643 > https://issues.apache.org/jira/browse/AMBARI-7643 > > > Repository: ambari > > > Description > ------- > > The same job query shows correct # of bytes in 1.6.1 built-in jobs tab (see > attached screenshot), whereas it shows 0 bytes in 1.7.0 jobs view. > > Turns out that in Ambari 1.7.0, the Ember javascript library was updated from > 1.0-pre to 1.5. In 1.0-pre, attempting to get a field that does not exist > would return null, whereas in 1.5 it returns undefined (which cannot be added > to another number, hence resulting in dispalying 0 even though hdfsReadBytes > had a p > > > Diffs > ----- > > contrib/views/jobs/src/main/resources/ui/app/scripts/models/jobs/tez_dag.js > 5797120 > > Diff: https://reviews.apache.org/r/26335/diff/ > > > Testing > ------- > > Deployed the view to a cluster and verified that it worked. > > > Thanks, > > Alejandro Fernandez > >
