----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26386/#review55600 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Oct. 6, 2014, 6:55 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26386/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 6:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-7664 > https://issues.apache.org/jira/browse/AMBARI-7664 > > > Repository: ambari > > > Description > ------- > > The request ... > > {code} > GET http://c6401.ambari.apache.org:8080/api/v1/views/BadView > {code} > > ... where 'BadView' is not a deployed view, should return a 404. > > {code} > { > "status" : 404, > "message" : "The requested resource doesn't exist: View not found, > ViewInfo/view_name=BadView" > } > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java > 48767d5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java > 1d0eef4 > > Diff: https://reviews.apache.org/r/26386/diff/ > > > Testing > ------- > > Manual tests. > > New unit test added. All existing tests pass ... > > > Results : > > Tests run: 2077, Failures: 0, Errors: 0, Skipped: 16 > ... > [INFO] Executed tasks > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 31:31.433s > [INFO] Finished at: Mon Oct 06 17:41:47 EDT 2014 > [INFO] Final Memory: 38M/476M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
