----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26412/#review55657 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Oct. 7, 2014, 11:09 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26412/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 11:09 a.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-7673 > https://issues.apache.org/jira/browse/AMBARI-7673 > > > Repository: ambari > > > Description > ------- > > The actual issue is that AGGREGATE alerts were attempting to be scheduled on > the service masters. AGGREGATE type alerts should not trigger hash > invalidations. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java > e4aa22241d123ae48d367eb2b1baf58d2e628e12 > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java > 10cd54ab0836e5e8cde7b4b29dba9b15fdf932ed > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java > 412b4d35bd74a8229f98094ea23b74f1f3a0de50 > > Diff: https://reviews.apache.org/r/26412/diff/ > > > Testing > ------- > > Added a test to verify that: > - AGGREGATE alerts don't trigger hash invalidations > - Definitions that are service-level do cause a host invalidation > > Existing tests are busted (see > https://builds.apache.org/job/Ambari-trunk-Commit/). I ran the tests anyway > and verified that the same ones failed, so there should not be more > regressions from my changes. > > Once trunk is fixed, I'll re-run the tests and push (assuming I get +1's on > the changes). > > > Thanks, > > Jonathan Hurley > >
