-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26468/
-----------------------------------------------------------
(Updated Oct. 8, 2014, 11:55 p.m.)
Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako.
Bugs: AMBARI-7707
https://issues.apache.org/jira/browse/AMBARI-7707
Repository: ambari
Description (updated)
-------
Unable to add a View.
STR
Install ambari
Navigate to
http://serverIP:8080/views/ADMIN_VIEW/1.0.0/INSTANCE/#/views/JOBS/versions/1.0.0/new
Fill all required fields
Press Save button
RESULT: Error in browser console.
This needs two +1s in order to be committed into branch-1.7.0 release candidate.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
40a90c8
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html
4bf51ac
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/modals/create.html
9b15f44
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js
PRE-CREATION
Diff: https://reviews.apache.org/r/26468/diff/
Testing
-------
Reproduced and ensured that views can be created.
Also ran ambari-admin functional test and unit tests.
$ npm run test-single-run
INFO [karma]: Karma v0.12.16 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket ISQvXpNq5yHY5hw7Ftmw
with id 82072137
PhantomJS 1.9.7 (Mac OS X): Executed 2 of 2 SUCCESS (0.021 secs / 0.02 secs)
$ npm run protractor
...
Finished in 1.415 seconds
1 test, 0 assertions, 0 failures
Thanks,
Alejandro Fernandez
