-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26505/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-7711
    https://issues.apache.org/jira/browse/AMBARI-7711


Repository: ambari


Description
-------

1) When you add user to groups, or set permissions for users/groups, you have 
to explicitly press Enter before confirming the changes. This behavior is not 
clear for users as they usually just type the name and press confirmation 
button.

2) Should protect against navigating away from a form w/o saving changes. You 
enter one or more users into a box but don't click the check to save but then 
navigate away. You risk losing all of your changes. Need a "You have unsaved 
changed. Save now? Cancel/Discard/Save" popup when you attempt to navigate away 
from a page with a form that is in edit mode with changes.


Diffs
-----

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js
 6451387 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/directives/editableList.js
 f157d70 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js def09b1 
  ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 
e047a8d 
  ambari-admin/src/main/resources/ui/admin-web/package.json d7de8fc 
  ambari-admin/src/main/resources/ui/admin-web/test/karma.conf.js 1b815e5 
  
ambari-admin/src/main/resources/ui/admin-web/test/unit/directives/editablelist_test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/26505/diff/


Testing
-------

3 tests added


Thanks,

Andriy Babiichuk

Reply via email to